Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more hooks to tad and made existing ones more expressive #272

Merged

Conversation

NiclasHaderer
Copy link
Contributor

I added a new parameter to the onViewRowCount hook that allows me to distinguish the different counts the PivotRequester supports. In addition to that I added a onViewRowCountResolved hook which enables getting the rowCount.

@elefeint
Copy link
Contributor

Nothing useful to say, just that I read the title as "made existing ones more impressive" :)

Copy link
Owner

@antonycourtney antonycourtney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra hooks which enable more detailed logging / instrumentation. LGTM.

@antonycourtney antonycourtney merged commit c7e31fd into antonycourtney:master Jul 3, 2024
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants